Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ShareAPI): Send mails for mail shares by default #48381

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(ShareAPI): Send mails for mail shares by default #48381

wants to merge 3 commits into from
+19 −15

Commits on Oct 23, 2024

  1. fix(ShareAPI): Send mails for mail shares by default 

    It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.

Our UI does not have that at the moment so it should default to sending
emails always for mail shares.

Not exactly sure how this was handled earlier but this is a good starting point.

Resolves : #48012

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    faa96d3 View commit details
    Browse the repository at this point in the history

  2. fix(FileRequests): File requests should be type link share 

    "File request" is the new "File drop"... File drop was only possible on link shares.

The mails sent at the end of creating a file request is "sending the link to various emails"
it does should not turn the share type to email.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a154393 View commit details
    Browse the repository at this point in the history

  3. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @nextcloud-command
    nextcloud-command committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3dd0f4b View commit details
    Browse the repository at this point in the history