[stable33] fix(files_external): set usePresignedUrl before first S3 connection - #63457
Open
backportbot[bot] wants to merge 1 commit into
Open
[stable33] fix(files_external): set usePresignedUrl before first S3 connection#63457backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
isUsePresignedUrl() was read by preSignedUrl() before getConnection() ever ran, since the flag was only assigned as a side effect inside getConnection(). Any request path that never opens a real S3 client (e.g. a PROPFIND that only reads cached DB metadata) saw the flag stuck at its default false, so downloadURL/download-url-expiration came back empty even with use_presigned_url configured. Move the assignment into parseParams(), which runs at construction time for every S3 backend (primary storage and external storage), so the flag is correct regardless of whether a connection was ever opened. Fixes #59249 Signed-off-by: mostafa <mostafakhaki00@gmail.com>
backportbot
Bot
requested review from
Altahrim,
CarlSchwan,
come-nc,
icewind1991,
kesselb and
provokateurin
and removed request for
a team
August 21, 2026 13:14
kesselb
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #63417