fix(Middleware): return reasonable status codes

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
nextcloud · Apr 30, 2024 · 399e78c · 399e78c
1 parent d9fd0a2
commit 399e78c
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/lib/Middleware/PermissionMiddleware.php b/lib/Middleware/PermissionMiddleware.php
@@ -3,8 +3,11 @@
 namespace OCA\Tables\Middleware;
 
 use OCA\Tables\Errors\InternalError;
+use OCA\Tables\Errors\NotFoundError;
 use OCA\Tables\Errors\PermissionError;
 use OCA\Tables\Service\PermissionsService;
+use OCP\AppFramework\Controller;
+use OCP\AppFramework\Http;
 use OCP\AppFramework\Middleware;
 use OCP\AppFramework\Utility\IControllerMethodReflector;
 use OCP\IRequest;
@@ -87,4 +90,14 @@ protected function assertCanManageContext(): void {
 			}
 		}
 	}
+
+	public function afterException(Controller $controller, string $methodName, \Exception $exception) {
+		if ($exception instanceof PermissionError) {
+			return new Http\DataResponse(['message' => $exception->getMessage()], Http::STATUS_FORBIDDEN);
+		}
+		if ($exception instanceof NotFoundError) {
+			return new Http\DataResponse(['message' => $exception->getMessage()], Http::STATUS_NOT_FOUND);
+		}
+		throw $exception;
+	}
 }