Skip to content

Commit

Permalink
Merge pull request #1397 from nextcloud/update-workflow
Browse files Browse the repository at this point in the history
fix: use unique names for actions upload-artifact
  • Loading branch information
blizzz authored Oct 8, 2024
2 parents e5911fe + 3d44745 commit d2f19ee
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cypress-custom.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,24 +149,24 @@ jobs:
CYPRESS_ncVersion: ${{ matrix.server-versions }}
npm_package_name: ${{ env.APP_NAME }}

- name: Print logs
- name: Print logs ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
if: always()
run: |
cat /tmp/requestlog
cat data/nextcloud.log
- name: Upload test failure screenshots
- name: Upload test failure screenshots ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
uses: actions/upload-artifact@v4
if: failure()
with:
name: Upload screenshots
name: Upload screenshots ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
path: apps/${{ env.APP_NAME }}/cypress/screenshots/
retention-days: 5

- name: Upload nextcloud logs
- name: Upload nextcloud logs ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
uses: actions/upload-artifact@v4
if: failure()
with:
name: Upload nextcloud log
name: Upload nextcloud log ${{ matrix.node-version }}-${{ matrix.php-versions }}-${{ matrix.server-versions }}-${{ matrix.databases }}
path: data/nextcloud.log
retention-days: 5
4 changes: 2 additions & 2 deletions cypress/e2e/tables-table.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('Manage a table', () => {
cy.contains('button', 'Create row').should('be.visible')
cy.contains('h1', 'to do list').should('be.visible')
cy.contains('table th', 'Task').should('exist')
cy.contains('.paragraph-content', 'to Do List description').should('be.visible')
cy.contains('.text-editor__content p', 'to Do List description').should('be.visible')
})

it('Create with import', () => {
Expand Down Expand Up @@ -71,7 +71,7 @@ describe('Manage a table', () => {

cy.wait(10).get('.toastify.toast-success').should('be.visible')
cy.get('.app-navigation__list').contains('ToDo list').should('exist')
cy.contains('.paragraph-content', 'Updated ToDo List description').should('be.visible')
cy.contains('.text-editor__content p', 'Updated ToDo List description').should('be.visible')
})

it('Delete', () => {
Expand Down

0 comments on commit d2f19ee

Please sign in to comment.