Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove deleted resource from associated applications #1156

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jun 19, 2024

Fixes #1027

@enjeck enjeck added bug Something isn't working 3. to review Waiting for reviews labels Jun 19, 2024
@enjeck enjeck self-assigned this Jun 19, 2024
@blizzz
Copy link
Member

blizzz commented Jun 21, 2024

🤔 I thought we/I did it in the past 😕

lib/Db/ContextNodeRelationMapper.php Outdated Show resolved Hide resolved
lib/Service/ContextService.php Outdated Show resolved Hide resolved
lib/Service/ContextService.php Outdated Show resolved Hide resolved
@enjeck enjeck force-pushed the fix/1027 branch 2 times, most recently from b3d731e to 90a346c Compare July 2, 2024 03:41
@enjeck enjeck force-pushed the fix/1027 branch 2 times, most recently from b3d731e to d5da0f2 Compare July 17, 2024 15:45
@enjeck enjeck force-pushed the fix/1027 branch 2 times, most recently from 40a7aaa to 0af1177 Compare August 8, 2024 09:14
@enjeck enjeck requested a review from juliusknorr August 8, 2024 09:14
@enjeck enjeck force-pushed the fix/1027 branch 2 times, most recently from 71fe642 to c7d8245 Compare August 22, 2024 09:06
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@juliusknorr
Copy link
Member

🤔 I thought we/I did it in the past 😕

@blizzz Anything you'd want to still check in that regard?

@blizzz
Copy link
Member

blizzz commented Sep 3, 2024

🤔 I thought we/I did it in the past 😕

@blizzz Anything you'd want to still check in that regard?

I would fancy a database clean up (could be a run-once expensive/maintenance background job), but this can be a follow-up PR. Which can then also be dropped in a future version, still good practice to keep the DB neat and tidy.

src/pages/Context.vue Show resolved Hide resolved
@enjeck enjeck merged commit d492b98 into main Sep 11, 2024
61 checks passed
@enjeck enjeck deleted the fix/1027 branch September 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove deleted resource from associated Applications
3 participants