Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reuse compliance - Part 1 #1277

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Aug 5, 2024

As a first step convert a larger chunk of files to ship SPDX header where our converter won't be of any help...


SUMMARY

  • Bad licenses: 0
  • Deprecated licenses: 0
  • Licenses without file extension: 0
  • Missing licenses: 0
  • Unused licenses: 0
  • Used licenses: Apache-2.0, AGPL-3.0-or-later, MIT
  • Read errors: 0
  • Files with copyright information: 604 / 1179
  • Files with license information: 580 / 1179

@AndyScherzinger AndyScherzinger added technical debt Technical issue 2. developing Work in progress labels Aug 5, 2024
@AndyScherzinger AndyScherzinger self-assigned this Aug 5, 2024
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger changed the title Add reuse compliance Add reuse compliance - Part 1 Aug 5, 2024
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 5, 2024
@AndyScherzinger AndyScherzinger marked this pull request as ready for review August 5, 2024 18:53
@AndyScherzinger
Copy link
Member Author

one question maybe @elzody can help me with that. Any particular reason to replicate the server repo's image assets in https://github.com/nextcloud/tables/tree/main/cypress/styleguide/assets/img ? Just asking because I will have to replicate its license infos then.

@elzody
Copy link
Contributor

elzody commented Aug 5, 2024

@AndyScherzinger That was needed in order to support Cypress component tests for the interactive table widget, since the component tests don't run in a full-fledged e2e set up -- they just run by themselves, meaning we needed to import the styles, etc.

I can see now with the headers how it is problematic and creates a lot of work... not really sure initially if there's a better way to do it, since an e2e test would create a reliance on accessing the widget from another app in the tests. I can look into if there's a simpler way to do it so you don't have to re-do all of those, if possible

@AndyScherzinger
Copy link
Member Author

@elzody all good, no worries. Adding the license infos for spdx/reuse isn't an issue or a lot of effort since that info is already available from/in the server repo. So don't worry. Fine to keep the files as they are at the moment 👍

@juliusknorr juliusknorr merged commit c7da9e6 into main Aug 6, 2024
60 checks passed
@juliusknorr juliusknorr deleted the chore/noid/reuse-compliance branch August 6, 2024 19:15
@AndyScherzinger AndyScherzinger added this to the v0.8.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants