fix(Import): expect selectionOptions as array from json #1383
Conversation
|
We should check with the usergroup column types, too. |
lib/Dto/Column.php
Outdated
| @@ -23,7 +23,7 @@ public function __construct( | |||
| private ?int $numberDecimals = null, | |||
| private ?string $numberPrefix = null, | |||
| private ?string $numberSuffix = null, | |||
| private ?string $selectionOptions = null, | |||
| private ?array $selectionOptions = null, | |||
There was a problem hiding this comment.
Hmm, are we sure about this? I believe selectionOptions is a comma-delimited string. Maybe it's only shown as a string in the frontend, idk.
There was a problem hiding this comment.
from my debugging yes, and the change worked locally.
|
@blizzz My suggestion for fixing this issue is updating this line https://github.com/nextcloud/tables/blob/main/lib/Controller/ApiTablesController.php#L160 to Otherwise, we have to update the data type in both ColumnController and frontend |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/noid/import-selectionoptions
branch
from
7e80e04
to
c288a3e
Compare
|
Changed to Luka's suggestion |
|
/backport to stable0.8 |
|
@luka-nextcloud mind reviewing this one? 🙈 |
backportbot
bot
removed
the
backport-request
currently an import fails silently (no web UI feedback) with
Argument #15 ($selectionOptions) must be of type ?string, array givenin the logs. This fixes handlig of the selectionOptions.