Enh/views menu and views modal #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
juliusknorr
reviewed
Jul 31, 2023
juliusknorr
reviewed
Jul 31, 2023
added 5 commits
August 1, 2023 08:23
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian <florian.steffens@nextcloud.com>
datenangebot
pushed a commit
that referenced
this pull request
Aug 11, 2023
* Enables creating, editing and deleting views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * enh(view): Enables sharing and integration of views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * adjust, shorten menus, change icon and fix typo Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * changed icon, add button to reset local view config Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * changed icon, add button to reset local view config Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * changed icon, add button to reset local view config Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * wording: clone -> duplicate Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * cleanup Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> --------- Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> Signed-off-by: Florian <florian.steffens@nextcloud.com> Co-authored-by: Philipp Hempel <Philipp.Hempel1@web.de>
datenangebot
pushed a commit
that referenced
this pull request
Aug 11, 2023
* preparations for views on BE side Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Handover Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * views: Shows all views and displays them Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Enables creating, editing and deleting views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * feat(views navigation): Show views of all tables beneath them Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * fix(views): Repairing main view functions (Edit, Delete) Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * enh(edit view): Enables Sorting in views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * enh(view): Enables sharing and integration of views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * work in progress Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * work in progress Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Implements backend logic for filtering and extracting the relevant rows Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Creates first mockup for frontend filter UI Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fixing after rebase Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Finishes filter ui Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * fixes backend filtering with magic values Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * implements orderBy in the backend Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Implements orderBy in the frontend Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Breaking Change: Replaces tables with base views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Removes empty filters and sorting rules before saving view Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Create columns from every view and select to which view to add them Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Refactor column menu for frontend view filtering and more Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Enh: New features: Reset view config, save it or create new view with it Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Enh: Menu reordering Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Show meta columns Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Restructures the edit column settings and therefore also the edit column modal Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * fix: Fixing textlink column Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fix: Import now works again Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fix: Global search for views works Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fix: Smart Picker Fix Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Integration of link to a specific row of a table; Preparation for more Link Previews Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Small fixes: Renaming, create shares, selection check filtering Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Implements new permission handling Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Implements new permission handling in the frontend + some adjustments Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Solves unauthorised concurrency problem and fixes column create/edit bugs Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Small fixes Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Small backend fixes Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Design improvements: Edit view Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Design improvements: Column header options Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Design improvements: Sidebar Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Design improvement: Other enhancements like view templates Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fix: Muliple shares are merged correctly to provide the permissions for the share receiver, small refactoring Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fixes migration of existing data Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * First step of cleanup, Solves TODOs Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Second step of cleanup, Format code, linting Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fix: Fixes sharing bugs Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * refactor: Resolving some code reviews Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Propper logging of exceptions Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * fix: permission bug fixes, apply additional frontend filters Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Updated API Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fix: Small bugfix for creating templates Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Refactor: Cleaning php code, exception handling, documentation, etc. Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Security: Send only data from columns from the corresponding view to the frontend Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Import for not base views + Mandatory & parsing check Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Enh/views menu and views modal (#435) * Enables creating, editing and deleting views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * enh(view): Enables sharing and integration of views Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * adjust, shorten menus, change icon and fix typo Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * changed icon, add button to reset local view config Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * changed icon, add button to reset local view config Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * changed icon, add button to reset local view config Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * wording: clone -> duplicate Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * cleanup Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> --------- Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> Signed-off-by: Florian <florian.steffens@nextcloud.com> Co-authored-by: Philipp Hempel <Philipp.Hempel1@web.de> * WIP: Removes base views, adds dashboard Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * WIP: Adding Table to Dashboard Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fixes most functionality Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * feat: Save/create view with frontend config repaired and improved Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fix: Create view repair, sharing shared elements possible now Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Prepares NcTable component for reusability Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * updated dashboard Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * View settings for hidden properties Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Refactor: reordering of structure of branch and clean up Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * move all modals into a new module -> modals are independent from any modules etc. so it's good to have them in one place together Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * WIP, update Florian - Dashboard edit table name and emoji make edit view and delete view usable remove hover-effects - add delete table modal - add delete view modal (was inline before) - cleanup modals structure - rename some "dashboard" to "Table" names - add routes and methods to update tables (title && emoji) - no routing after update view settings by default - fix typos Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * small bug fixes Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * WIP pgsql compatibility Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Revert row path changes due to bugs and no time to fix Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Implements filter and sorting functionality for PostgreSQL Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fixes bugs: Show views shared with group, jump to created view, open table collapsable with view, improving searching, viewSetting in table Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Fixes small create view bug Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Update and cleanup API Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Show row id in url for row widget Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Small bug fixes Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * psalm fixes Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * WIP add custom smart picker Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * WIP smart picker with content views Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * WIP make NcTable scrollable in widget Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Makes ncTable reusable and thus the widgets working Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * code cleanup Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * fix unit tests Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * ci fixes Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * ci fixes Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * add editTable options Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * cypress fixes Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Small bug fixes and clean up Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * chore: Add cypress project id Signed-off-by: Julius Härtl <jus@bitgrid.net> * remove sqlite compatibility temporary Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * limit widget height for table content views Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * ci: Remove cypress debug for cleaner output Signed-off-by: Julius Härtl <jus@bitgrid.net> * ci: Record cypress runs in CI Signed-off-by: Julius Härtl <jus@bitgrid.net> * adjustments for case-insensitive way Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Update npm deps Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * fix space in column description outputs Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Nicer fox of space in column description outputs Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * fix data-table heading Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Release preparation Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Design: Main Column actions as inline icons to avoid scrolling by default https://image-us.samsung.com/SamsungUS/support/solutions/apps/APPS_SN_More-options_Share-icon.png?$default-high-resolution-jpg$ Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * Fix: Reset and apply view setting Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Improves views dashboard table Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> * Move detail info for table or view into sidebar description remove from dashboard view Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * fix Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * chore: Cleanup unused row widget Signed-off-by: Julius Härtl <jus@bitgrid.net> * fix: Hide actions, filter, hide columns in widgets Signed-off-by: Julius Härtl <jus@bitgrid.net> * add menu to "data" heading Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * npm update package-lock.json Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * lint fixes Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> * add package-lock.json Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> --------- Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com> Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de> Signed-off-by: Florian <florian.steffens@nextcloud.com> Signed-off-by: Julius Härtl <jus@bitgrid.net> Co-authored-by: Florian Steffens <florian.steffens@nextcloud.com> Co-authored-by: Julius Härtl <jus@bitgrid.net>
|
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.