-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Application sharing frontend #966
Conversation
ce7c5c7
to
56396a4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
96a45f0
to
54cc20c
Compare
1929d95
to
61255b0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
54cc20c
to
d164cb2
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
resolved conflicts from rebase |
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- that is through the internal endpoints /tables/table and /tables/view Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
<div class="col-4"> | ||
{{ t('tables', 'Share with accounts') }} | ||
</div> | ||
<NcSelect v-model="preExistingSharees" style="width: 100%;" :loading="loading" :options="options" | ||
:placeholder="getPlaceholder()" | ||
:searchable="true" :get-option-key="(option) => option.key" | ||
label="displayName" | ||
:aria-label-combobox="getPlaceholder()" :user-select="true" | ||
:close-on-select="false" | ||
:multiple="true" | ||
@search="asyncFind" @input="addShare"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that we already have several NcSelect
s that search for users/groups duplicated across other pages. Thinking about how to consolidate into just one and reuse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be very nice indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enjeck Could you file a follow up issue
Adds a way to share contexts as well as permission for associated context resources