Merge pull request #159 from lrholmes/fix-false-variant-case

fix: Support false-only variant with fallback behaviour
nextui-org · Feb 12, 2024 · 183f21d · 183f21d
2 parents a26d801 + a3c2bd3
commit 183f21d
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/src/__tests__/tv.test.ts b/src/__tests__/tv.test.ts
@@ -334,6 +334,42 @@ describe("Tailwind Variants (TV) - Default", () => {
     expect(h1({bool: undefined})).toHaveClass(["text-3xl", "truncate"]);
   });
 
+  test("should support false only variant", () => {
+    const h1 = tv({
+      base: "text-3xl",
+      variants: {
+        bool: {
+          false: "truncate",
+        },
+      },
+    });
+
+    expect(h1()).toHaveClass(["text-3xl", "truncate"]);
+    expect(h1({bool: true})).toHaveClass(["text-3xl"]);
+    expect(h1({bool: false})).toHaveClass(["text-3xl", "truncate"]);
+    expect(h1({bool: undefined})).toHaveClass(["text-3xl", "truncate"]);
+  });
+
+
+  test("should support false only variant -- default variant", () => {
+    const h1 = tv({
+      base: "text-3xl",
+      variants: {
+        bool: {
+          false: "truncate",
+        },
+      },
+      defaultVariants: {
+        bool: true,
+      },
+    });
+
+    expect(h1()).toHaveClass(["text-3xl"]);
+    expect(h1({bool: true})).toHaveClass(["text-3xl"]);
+    expect(h1({bool: false})).toHaveClass(["text-3xl", "truncate"]);
+    expect(h1({bool: undefined})).toHaveClass(["text-3xl"]);
+  });
+
   test("should support boolean variants -- default variants", () => {
     const h1 = tv({
       base: "text-3xl",

diff --git a/src/index.js b/src/index.js
@@ -217,7 +217,7 @@ export const tv = (options, configProp) => {
           ? variantKey
           : falsyToString(defaultVariantProp);
 
-      const value = variantObj[key] || variantObj["false"];
+      const value = variantObj[key || "false"];
 
       if (
         typeof screenValues === "object" &&