-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for slot level variant overrides #82
Conversation
76132cc
to
4883352
Compare
Amazing! Huge thanks @mskelton , could you please fix the conflicts? |
7200405
to
b8f2cff
Compare
@jrgarciadev I've fixed the conflicts. |
@mskelton would you like to write a section about this in the docs? https://github.com/nextui-org/tailwind-variants-docs, in here: https://www.tailwind-variants.org/docs/slots |
6333cf6
to
875adde
Compare
@jrgarciadev PR opened with docs for this feature. |
@jrgarciadev Can we get this PR merged as well as my docs PR? |
@tianenpang could you please take a look at this PR? |
@mskelton something that I just noticed is that the speed is lower than the current version, here's the benchmark with these changes TV without slots & tw-merge (enabled) x 436,739 ops/sec ±0.40% (96 runs sampled) Here is the current one: Fastest is TV without slots & tw-merge (disabled) Could you please check why? 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks to @mskelton for this awesome feature 🚀
Hi @jrgarciadev I've made some optimizations to the performance, please try benchmarking again. |
Amazing the performance is even better than the current one, thank you @tianenpang 🙏🏻 |
Fixes #48
Description
This adds support for slot level variant overrides. This is useful in a variety of situations:
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).