-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial TypeScript type declarations #217
base: master
Are you sure you want to change the base?
Conversation
🎉 Initial working types implementation 🔥 Remove unused import
@tbazin thank you for your work on this! It seems maintenance has stalled. Feel free to keep updating this PR. Since review is taking awhile, another alternative to sharing these would be to send them to DefinitelyTyped. Perhaps while awaiting review, you might consider pushing these types to DefinitelyTyped so that others may more easily benefit from your work. Hopefully NexusUI will see native types and more regular maintenance at some point, but until then, you’ll probably have an easier time getting your contributions merged there. |
Hi!
Here's a first proposition for bundled TS type declarations.
It's probably not perfectly clean, I wasn't sure what to do with private class methods for instance, and ultimately I believe the library could be rewritten in native TypeScript, alleviating the need for such a decoupled approach, but that should already be quite a usable basis!