Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reviewer suggestions in PR #122 #124

Merged
merged 3 commits into from
Apr 4, 2024
Merged

add reviewer suggestions in PR #122 #124

merged 3 commits into from
Apr 4, 2024

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

Added reviewer suggestion for version 2.2.0 release (#122)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 820e7cf

+| ✅ 172 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-04 07:31:05

@Daniel-VM Daniel-VM marked this pull request as draft April 3, 2024 09:47
d4straub
d4straub reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@Daniel-VM Daniel-VM marked this pull request as ready for review April 4, 2024 07:12
@Daniel-VM @d4straub
Update .github/CONTRIBUTING.md in nf-core#124
820e7cf 
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
d4straub
d4straub approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Daniel-VM Daniel-VM merged commit 4a8016a into nf-core:dev Apr 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-VM @d4straub