Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix samples reported of prokka/bakta in multiqc report #134

Merged
merged 3 commits into from
May 17, 2024

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

This PR fixes sample reporting of prokka/bakta section in mutlqc report.
Closes #132

Daniel-VM added a commit to Daniel-VM/bacass that referenced this pull request May 16, 2024
Copy link

github-actions bot commented May 16, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit 495debc

+| ✅ 196 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-17 08:00:30

@Daniel-VM
Copy link
Contributor Author

Daniel-VM commented May 16, 2024

(Failed tests will pass after merging nf-core template update v2.14.1 )

@Daniel-VM Daniel-VM marked this pull request as ready for review May 17, 2024 07:59
@Daniel-VM Daniel-VM added the bug Something isn't working label May 17, 2024
@Daniel-VM
Copy link
Contributor Author

Thanks @maxulysse 🙌🏾

@Daniel-VM Daniel-VM merged commit 3a51224 into nf-core:dev May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants