Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.0.0 release review fixes #50

Merged
merged 22 commits into from
Apr 12, 2024
Merged

V1.0.0 release review fixes #50

merged 22 commits into from
Apr 12, 2024

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Apr 12, 2024 •
edited
Loading

Release PR review fixes:

  • Update download CI
  • README refinements
  • Error in recording anota2seq version
  • ... and more

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/riboseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0641734

+| ✅ 173 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.ribo_database_manifest
  • files_unchanged - File ignored due to lint config: assets/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-12 14:18:54

@pinin4fjords pinin4fjords mentioned this pull request Apr 12, 2024
Merged
10 tasks
FelixKrueger
FelixKrueger approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@FelixKrueger FelixKrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nod.

maxulysse
maxulysse reviewed Apr 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
@pinin4fjords pinin4fjords merged commit 9f56a37 into dev Apr 12, 2024
107 of 109 checks passed
@pinin4fjords pinin4fjords deleted the v1.0.0_release_review_fixes branch April 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@FelixKrueger FelixKrueger FelixKrueger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinin4fjords @maxulysse @FelixKrueger