-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.3 Updates: Fixes for contamination, UMI Handling, Template 2.11.1 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting changes to a non-linted version and added the umitools modules.
Added the umitools workflow and integrated it into the smrnaseq workflow
Add additional documentation to use UMI tools as part of the pipeline. Most of the documentation has been copied from nf-core/rnaseq.
The bam2fq module is neccessary to convert the deduplicated bam files back into a fastq format to be fed into the existing pipeline.
Added the umitools extract modules.config lines from nf-core/rnaseq to this pipeline.
Added configurations for umi deduplication.
Initial comit of the umi dedup subworkflow. The workflow combines already existing modules of the pipeline and nf-core module to deduplicate the reads by mapping them to the species genome and re-converting them to fastq after deduplication.
includes the optional umitools deduplication step after the read QC.
Added additional configuration to change the output file name of samtools sort.
Added the documentation detailing the output files of the UMI-tools deduplication step.
After deduplication the reads that remained unaligned to the provided reference genome are merged with the set of deduplicated reads to enable the use of the full spectrum of reads, independent of potential reference bias. This behaviour can be deactivated by setting --umi_merge_unmapped false
Information on the new --umi_merge_unmapped command were added to both the CHANGELOG, as well as the output markdown script.
Includes the nf-core cat module to replace the custom concatenation module.
Implements the use of the nf-core cat module.
deletes the now unused conatenation module.
maxulysse
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
@nf-core-bot fix linting |
grst
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #114
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).