Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3 Updates: Fixes for contamination, UMI Handling, Template 2.11.1 #303

Merged
merged 126 commits into from
Jan 24, 2024

Conversation

apeltzer
Copy link
Member

Related to #114

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Christian Kubica and others added 30 commits May 10, 2022 14:35
Reverting changes to a non-linted version and added the umitools modules.
Added the umitools workflow and integrated it into the smrnaseq workflow
Add additional documentation to use UMI tools as part of the pipeline.
Most of the documentation has been copied from nf-core/rnaseq.
The bam2fq module is neccessary to convert the deduplicated bam
files back into a fastq format to be fed into the existing
pipeline.
Added the umitools extract modules.config lines from nf-core/rnaseq
to this pipeline.
Added configurations for umi deduplication.
Initial comit of the umi dedup subworkflow. The workflow combines
already existing modules of the pipeline and nf-core module to
deduplicate the reads by mapping them to the species genome and
re-converting them to fastq after deduplication.
includes the optional umitools deduplication step after the read
QC.
Added additional configuration to change the output file name of
samtools sort.
Added the documentation detailing the output files of the UMI-tools
deduplication step.
After deduplication the reads that remained unaligned to the
provided reference genome are merged with the set of deduplicated
reads to enable the use of the full spectrum of reads, independent
of potential reference bias. This behaviour can be deactivated by
setting --umi_merge_unmapped false
Information on the new --umi_merge_unmapped command were added to
both the CHANGELOG, as well as the output markdown script.
Includes the nf-core cat module to replace the custom concatenation
module.
Implements the use of the nf-core cat module.
deletes the now unused conatenation module.
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

@grst
Copy link
Member

grst commented Jan 22, 2024

@nf-core-bot fix linting

Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@apeltzer apeltzer merged commit 0f3aff3 into dev Jan 24, 2024
10 checks passed
@apeltzer apeltzer deleted the umi-handling branch January 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants