Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core tools bump-version command does not preserve formatting #2206

Closed
fabianegli opened this issue Mar 19, 2023 · 3 comments
Closed

nf-core tools bump-version command does not preserve formatting #2206

fabianegli opened this issue Mar 19, 2023 · 3 comments

Comments

@fabianegli
Copy link
Contributor

Description of feature

When running nf-core bump-version 1.1.0 I get the following diff:

% git diff
diff --git a/nextflow.config b/nextflow.config
index ee0fca4..c249288 100644
--- a/nextflow.config
+++ b/nextflow.config
@@ -366,7 +366,7 @@ manifest {
     description     = """Quantitative Mass Spectrometry nf-core workflow"""
     mainScript      = 'main.nf'
     nextflowVersion = '!>=22.10.1'
-    version         = '1.1dev'
+    version = '1.1.0'
     doi             = ''
 }

but would expect

% git diff
diff --git a/nextflow.config b/nextflow.config
index ee0fca4..c249288 100644
--- a/nextflow.config
+++ b/nextflow.config
@@ -366,7 +366,7 @@ manifest {
     description     = """Quantitative Mass Spectrometry nf-core workflow"""
     mainScript      = 'main.nf'
     nextflowVersion = '!>=22.10.1'
-    version         = '1.1dev'
+    version         = '1.1.0'
     doi             = ''
 }

instead.

@fabianegli fabianegli changed the title nf-core tools bump versoin command does not preserve formatting nf-core tools bump-versoin command does not preserve formatting Mar 19, 2023
@maxulysse maxulysse changed the title nf-core tools bump-versoin command does not preserve formatting nf-core tools bump-version command does not preserve formatting Nov 13, 2023
@fabianegli
Copy link
Contributor Author

Sorry for the dupe 🤭 @maxulysse

@maxulysse
Copy link
Member

Sorry for the dupe 🤭 @maxulysse

no worries, it happens to the best ;-)

@fabianegli
Copy link
Contributor Author

Closing as fixed in #2514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants