-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect indentation on version bump #2514
respect indentation on version bump #2514
Conversation
This PR will prevent me form opening another duplicate of my own issue 🤣 I think it would be great to have a small specific test for that 😉 And I would have gone with capturing the spaces for preservation. Something like this: rf"version(\s*)=\s*[\'\"]?{re.escape(current_version)}[\'\"]?",
rf"version\1= '{new_version}'", |
Codecov Report
@@ Coverage Diff @@
## dev #2514 +/- ##
==========================================
- Coverage 70.53% 70.50% -0.04%
==========================================
Files 87 88 +1
Lines 9456 9519 +63
==========================================
+ Hits 6670 6711 +41
- Misses 2786 2808 +22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it ❤️
happy now with it, @fabianegli? |
Very 😄 |
fixes #2206