Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module environment.yaml linting #2515

Closed
2 tasks
edmundmiller opened this issue Nov 13, 2023 · 3 comments
Closed
2 tasks

Module environment.yaml linting #2515

edmundmiller opened this issue Nov 13, 2023 · 3 comments
Labels
linting modules Related to tools for working with DSL2 modules

Comments

@edmundmiller
Copy link
Contributor

edmundmiller commented Nov 13, 2023 •
edited
Loading

Tasks
Beta Give feedback
@edmundmiller edmundmiller added linting modules Related to tools for working with DSL2 modules labels Nov 13, 2023
@edmundmiller edmundmiller added this to the 2.11 milestone Nov 13, 2023
@edmundmiller edmundmiller mentioned this issue Nov 13, 2023
Merged
@maxulysse
Copy link
Member

Can we add some linting to ensure that the name is all lowercase?

@mashehu
Copy link
Contributor

mashehu commented Nov 14, 2023

it's not always lowercase: https://github.com/nf-core/modules/blob/master/modules/nf-core/multiqc/meta.yml

@edmundmiller edmundmiller changed the title Make sure the name field in environment.yml matches the name field in meta.yml Module environment.yaml linting Nov 21, 2023
@ewels ewels modified the milestones: 2.11, 2.12 Dec 8, 2023
@mirpedrol mirpedrol mentioned this issue Jan 22, 2024
Merged
@mirpedrol
Copy link
Member

Done with #2490 and #2676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linting modules Related to tools for working with DSL2 modules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ewels @maxulysse @mashehu @mirpedrol @edmundmiller