Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: environment.yml name must be lowercase #2676

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Linting: environment.yml name must be lowercase #2676

merged 2 commits into from
Jan 24, 2024

Conversation

mirpedrol
Copy link
Member

Close #2515

Linting that the name matches the one in meta.yml was done with #2490
All names were changed to lowercase with nf-core/modules#4332

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (31c61ca) 73.41% compared to head (aae4801) 73.46%.

Files Patch % Lines
nf_core/modules/lint/environment_yml.py 66.66% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit b0eb8d2 into nf-core:dev Jan 24, 2024
36 checks passed
@mirpedrol mirpedrol deleted the lint-environment branch January 24, 2024 12:14
@mirpedrol mirpedrol mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@edmundmiller edmundmiller edmundmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirpedrol @mashehu @edmundmiller @nf-core-bot