2862 fix determine base dir #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a config before we start iterating up the tree
This comment was marked as resolved.
This comment was marked as resolved.
ewels
approved these changes
Mar 19, 2024
|
Ah yeah probably do. Just my bad habit of not doing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the
determine_base_dirmethod which meant that nested dir configs were not properly accounted for.See https://nfcore.slack.com/archives/C06P9UX9T5W/p1710761810813619 for more info
PR checklist
CHANGELOG.mdis updateddocsis updated