Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate pipeline institutional configs in template #2936

Merged
merged 4 commits into from
May 2, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Apr 26, 2024

As this should be supported now though here: nf-core/configs#674

Meaning devs don't need to touch the section of the config, and users can add configs when they need

@jfy133 jfy133 changed the base branch from master to dev April 26, 2024 06:58
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the nf-core/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133
Copy link
Member Author

jfy133 commented Apr 26, 2024

@nf-core-bot fix linting

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (cdebded) to head (91d264b).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfy133 jfy133 requested a review from mashehu April 26, 2024 07:49
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge #2404 first I think, to not add more merge conflicts there.

@jfy133
Copy link
Member Author

jfy133 commented Apr 26, 2024

We should merge #2404 first I think, to not add more merge conflicts there.

Would this effect that at all? Does the TUI pipeline creation effect the config file?

But OK

@mashehu
Copy link
Contributor

mashehu commented Apr 26, 2024

I think we made some fine-tuning changes in the template, which could be with this file. But open for @mirpedrol to prove me wrong, when she is back. 🙂

@mirpedrol
Copy link
Member

This PR can be merged without any conflicts with #2404, thanks for double ckecking! 🙏

@mashehu mashehu merged commit 7b1073e into dev May 2, 2024
35 checks passed
@mashehu mashehu deleted the activate-pipeline-cofnigs branch May 2, 2024 08:11
@jfy133
Copy link
Member Author

jfy133 commented May 2, 2024

Woohoo1 Nice thank you all, will merge the other one on configs and 🤞 nothing breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants