Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -profile wave to the template. #2941

Merged
merged 7 commits into from
May 2, 2024
Merged

Added -profile wave to the template. #2941

merged 7 commits into from
May 2, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Apr 30, 2024

Add a config profile in the template to use Wave.

Note

Requires 24.03.0-edge! I considered bumping nextflowVersion to 24.04.0 but it feels a bit overkill when the vast majority of end users will not be using -profile wave. I'm inclined to mention this in the docs but not encode it in the config. Please shout if you disagree.

Will need more docs about Wave, but that's a larger effort, probably for the website repo.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels added the template nf-core pipeline/component template label Apr 30, 2024
@ewels ewels changed the base branch from master to dev April 30, 2024 13:29
@ewels ewels changed the title Profile wave Added -profile wave to the template. Apr 30, 2024
@nf-core nf-core deleted a comment from github-actions bot Apr 30, 2024
@ewels
Copy link
Member Author

ewels commented Apr 30, 2024

If someone could add this into upstream pipelines to be sure we're not going to hit any unexpected errors, that'd be fab.

Maybe Sarek @maxulysse @FriederikeHanssen, and rnaseq someone else, at least?

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@maxulysse
Copy link
Member

If someone could add this into upstream pipelines to be sure we're not going to hit any unexpected errors, that'd be fab.

Maybe Sarek @maxulysse @FriederikeHanssen, and rnaseq someone else, at least?

I'll have a look at adding that in both in POC PR

@maxulysse
Copy link
Member

nextflow run . -profile test,wave --outdir results -resume

ERROR ~ Error executing process > 'NFCORE_RNASEQ:PREPARE_GENOME:UNTAR_SALMON_INDEX (salmon.tar.gz)'

Caused by:
  Wave invalid response: [400] {"message":"Attribute `buildRepository` must be specified when using freeze mode"}


 -- Check '.nextflow.log' file for details
ERROR ~ Pipeline failed. Please refer to troubleshooting docs: https://nf-co.re/docs/usage/troubleshooting

 -- Check '.nextflow.log' file for details

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working as expected

@maxulysse
Copy link
Member

working locally: nf-core/rnaseq#1291

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
@maxulysse
Copy link
Member

We need docs for it, plus bumping the minimal Nextflow version

This comment was marked as off-topic.

@ewels ewels marked this pull request as draft April 30, 2024 15:13
@ewels ewels marked this pull request as ready for review April 30, 2024 15:19
@ewels ewels merged commit 5230590 into nf-core:dev May 2, 2024
35 checks passed
@ewels ewels deleted the profile-wave branch May 2, 2024 09:52
apptainer.ociAutoPull = true
singularity.ociAutoPull = true
wave.enabled = true
wave.freeze = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the documentation that we would need to provide wave.build.repository together with wave.freeze = true. Is it required? Would it be safer to let users provide both parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template nf-core pipeline/component template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants