Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master for 2.14.0 #2958

Merged
merged 409 commits into from
May 8, 2024
Merged

Dev -> Master for 2.14.0 #2958

merged 409 commits into from
May 8, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented May 7, 2024

No description provided.

ewels and others added 30 commits March 19, 2024 15:52
Gives an error message if safe_get() returns 401 (wrong GITHUB_TOKEN?)
Rename nf-test template files
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
…-values

Add type of values to the error description for schema errors
Uses a click callback function to normalize the name of a module/subworkflow
that is provided by the user on the CLI, so that names written in uppercase
still resolve to the expected lowercase name.

In case no argument is provided, the callback function simply returns None,
and thus the current behaviour of a user being asked to select a component
via an interactive prompt is maintained.

The .casefold() method is used in favour of .lower() for slightly
more robust case normalization.
See: https://stackoverflow.com/questions/45745661/lower-vs-casefold-in-string-matching-and-converting-to-lowercase

The callback is applied to all occurrences of "tool/module/subworkflow" arguments,
except those in the the "create" functions, because these already contain an internal
check that prompts to user to adhere to the lowercase naming convention.

Updates to CHANGELOG.md.

Co-authored-by: Adam Talbot <adam.talbot@seqera.io>
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
Co-authored-by: Arthur Gymer <24782660+awgymer@users.noreply.github.com>
The subworkflow info command referred to the subworkflow name
as "tool" in its list of arguments. It has been renamed to
"subworkflow" to align with the other subworkflow commands.
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 86.70213% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 75.34%. Comparing base (f4871ef) to head (293c781).
Report is 61 commits behind head on master.

Files Patch % Lines
nf_core/download.py 88.67% 12 Missing ⚠️
nf_core/__main__.py 84.61% 4 Missing ⚠️
nf_core/modules/modules_utils.py 50.00% 3 Missing ⚠️
nf_core/components/lint/__init__.py 77.77% 2 Missing ⚠️
nf_core/components/nfcore_component.py 50.00% 2 Missing ⚠️
nf_core/components/components_command.py 0.00% 1 Missing ⚠️
nf_core/lint_utils.py 94.44% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu merged commit 671e1df into master May 8, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.