Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEMPLATE: Parallelize pipeline GHA tests over docker/conda/singularity #3214

Merged
merged 17 commits into from
Oct 11, 2024

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse
Copy link
Member Author

continue from #3149

@maxulysse
Copy link
Member Author

@nf-core-bot fix linting pretty please 🙏

nf_core/pipeline-template/.github/workflows/ci.yml Outdated Show resolved Hide resolved
nf_core/pipeline-template/.github/workflows/ci.yml Outdated Show resolved Hide resolved
nf_core/pipeline-template/.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.51%. Comparing base (3b8cd7f) to head (3bd7105).
Report is 18 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxulysse
Copy link
Member Author

we also need singularity and conda setup as well

@maxulysse
Copy link
Member Author

In usage already in nf-core/bamtofastq#96

nf_core/pipeline-template/.github/workflows/ci.yml Outdated Show resolved Hide resolved
nf_core/pipeline-template/.github/workflows/ci.yml Outdated Show resolved Hide resolved
Comment on lines 73 to 80
- name: Set up Conda
if: matrix.profile == 'conda'
run: |
nextflow run ${GITHUB_WORKSPACE} -profile test,singularity --outdir ./results
if: "{% raw %}${{ github.base_ref == 'master' }}{% endraw %}"
conda clean -a
conda install -n base conda-libmamba-solver
conda config --set solver libmamba
echo $(realpath $CONDA)/condabin >> $GITHUB_PATH
echo $(realpath python) >> $GITHUB_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these shouldn't be needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copy pasted from modules

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so which part should I remove there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxulysse and others added 5 commits October 10, 2024 16:59
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol
Copy link
Member

Linting is failing because of the location of some of the {% raw %} and {% endraw %}, you can use less of them, let me know if I should give it a try so that I don't interfere with your commits to the same branch

@maxulysse maxulysse changed the title Parallelize pipeline GHA tests over docker/conda/singularity TEMPLATE: Parallelize pipeline GHA tests over docker/conda/singularity Oct 10, 2024
@maxulysse
Copy link
Member Author

What's the code for the CHANGELOG?

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@maxulysse maxulysse merged commit 88dc61c into dev Oct 11, 2024
84 checks passed
@maxulysse maxulysse deleted the maxulysse-patch-6 branch October 11, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants