-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeliCa: check for 212 kbit tag if no 424 kbit tags are found #94
base: master
Are you sure you want to change the base?
Conversation
Some FeliCa cards only respond to 212 kbit polling requests (for instance Hong Kong metro aka Octopus cards) so we should poll for them after checking for 424 kbit high-speed functionality Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, have you tested it ?
Yes has been tested |
if (candidates_count < 0) | ||
return NULL; | ||
|
||
// Poll for a FELICA 212 kbit tag (only if no 424 kbit tag was found) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we list both 212 and 424 kbit tags instead of listing 212 tags when no 424 is found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess one could... but does libfreefare support multiple readers? If not then it doesn't make too much sense to worry about that use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it does: as far as I can recall, I ran the test suite with 2 devices and 1 or 2 cards on each. Has less communication problems than with 1 device and 3+ tags 😄
But sometimes my memory tricks on me, and I don't have this hardware anymore to check.
Some FeliCa cards only respond to 212 kbit polling requests
(for instance Hong Kong metro aka Octopus cards) so we should poll
for them after checking for 424 kbit high-speed functionality
Signed-off-by: Matt Ranostay matt.ranostay@konsulko.com