Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Upgrade for React 16 #56

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

(WIP) Upgrade for React 16 #56

wants to merge 9 commits into from

Conversation

potench
Copy link
Contributor

@potench potench commented Jan 7, 2018

This is a work in progress.

Features

Update React Metrics to be compatible with React 16.

Problems

7 tests are currently failing, a few require redesign:

  • Tests are dependant on react-router 2, this needs to be upgraded to react-router 4
  • React 16 component error boundaries swallow errors, so intentionally testing for thrown errors in render() methods doesn't appear to work the same way.

@shimedh
Copy link

shimedh commented Jun 5, 2018

When will this available? Also will this library be making updates for future React versions?

@thongly
Copy link

thongly commented Jan 29, 2019

We are also waiting on this PR in order to use the package with our application. Any updates would be appreciated.

@aplassen
Copy link

Any updates on this?

As of React 16.9 this will be logged out as a warning:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move code from componentWillMount to componentDidMount (preferred in most cases) or the constructor.

Please update the following components: MetricsContainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants