-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/unitctl: Elaborate on features in unitctl readme. #1359
Conversation
Signed-off-by: Ava Hahn <a.hahn@f5.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool! A few minor changes, but otherwise looks good!
My review would mirror @javorszky's - otherwise lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply suggestions from code review
Co-authored-by: Gabor Javorszky <gabor@javorszky.co.uk>
I'm not sure this warrants a Co-authored-by
. Reviewers wouldn't normally expect to give a Co-developed-by
tag, unless maybe they suggested significant changes.
Besides, the tag we use for this is Co-developed-by
(and such a tag should be immediately followed by a Signed-off-by
)
This patch should of course be merged with the first one...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UNIT -> Unit, all changes are suggestions
Signed-off-by: Ava Hahn <a.hahn@f5.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I wanted the unitctl readme to elaborate on the how and the limitations of each function that the tool offers... not just a one-line description and an example. I added more text to each section. Please leave feedback if you feel there are any significant details left out.