tools/unitctl: Elaborate on features in unitctl readme. #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ava Hahn <a.hahn@f5.com>
javorszky
requested changes
Jul 15, 2024
|
My review would mirror @javorszky's - otherwise lgtm |
ac000
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Apply suggestions from code review
Co-authored-by: Gabor Javorszky <gabor@javorszky.co.uk>
I'm not sure this warrants a Co-authored-by. Reviewers wouldn't normally expect to give a Co-developed-by tag, unless maybe they suggested significant changes.
Besides, the tag we use for this is Co-developed-by (and such a tag should be immediately followed by a Signed-off-by)
This patch should of course be merged with the first one...
javorszky
requested changes
Jul 17, 2024
Signed-off-by: Ava Hahn <a.hahn@f5.com>
javorszky
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted the unitctl readme to elaborate on the how and the limitations of each function that the tool offers... not just a one-line description and an example. I added more text to each section. Please leave feedback if you feel there are any significant details left out.