Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/unitctl: make application directory configurable #1374

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

avahahn
Copy link
Contributor

@avahahn avahahn commented Jul 31, 2024

@avahahn avahahn requested a review from javorszky July 31, 2024 21:22
Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward changes, tested locally, unitctl builds, options shows up in help

@avahahn avahahn force-pushed the unitctl-application-dir branch 3 times, most recently from 510791a to 20533d4 Compare August 1, 2024 17:30
Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change, once done, merge away

tools/unitctl/README.md Outdated Show resolved Hide resolved
* default behavior is now a read write application mount
* use can specify a flag (-r) to mount app dir as read only

Signed-off-by: Ava Hahn <a.hahn@f5.com>
@avahahn avahahn merged commit a91b961 into nginx:master Aug 1, 2024
7 checks passed
@javorszky javorszky deleted the unitctl-application-dir branch August 1, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI Feature: make read only application mount configurable
2 participants