-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unitctl: rename app to apps #1424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably worth cleaning up the references to singular unitctl app
in the README.md
as part of this PR
Fixed in f5a4e44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash together the 3 commits that aren't whitespace/reordering lines, otherwise the net effect LGTM.
f5a4e44
to
0ef0ce4
Compare
squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unitctl: rename app -> apps, fix readme
Signed-off-by: Gabor Javorszky <g.javorszky@f5.com>
Prefix should really be tools/unitctl
for consistency, but I can live with just unitctl...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace: group and order command args
Signed-off-by: Gabor Javorszky <g.javorszky@f5.com>
Prefix should be tools/unitctl
(or just unitctl
depending on what you decide for the other commit). whitespace is little generic and doesn't really tell me anything...
Maybe just something like
unitctl: Whitespace fixes
0ef0ce4
to
654a655
Compare
@ac000 I fixed the commit subjects 🙂 |
Signed-off-by: Gabor Javorszky <g.javorszky@f5.com>
Signed-off-by: Gabor Javorszky <g.javorszky@f5.com>
654a655
to
5e8a689
Compare
Rebase with master. |
This PR achieves three separate things:
It does not fix the whole of the readme, that's a separate issue and PR.
Closes #1423