Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(requests): preventConcurrentRequest along with staleTime #486

Merged

Conversation

citruspress
Copy link
Contributor

This fixes #485

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

trackRequestResult no longer considers staleTime when skipping a request with status: fetching.

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

It's currently possible to have concurrent requests even if preventConcurrentRequest is true because all requests that are 'fetching' are also stale.

Issue Number: #485

What is the new behavior?

The stale time is not considered at all when deciding wether to skip a request or not for fetching requests.

An alternative solution would be to set the stale time for request that are fetching, but this seems like a cleaner solution.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

I cannot see a reason this would be breaking.

trackRequestResult no longer considers staleTime when skipping a request with status: fetching.

Previously it was possible to get concurrent requests even if preventConcurrentRequest was set
because all requests that were 'fetching' were also stale.
@stackblitz
Copy link

stackblitz bot commented Sep 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit b5abab0 into ngneat:master Sep 18, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trackRequestResult with staleTime and preventConcurrentRequest doesn't prevent concurrent requests
3 participants