fix(requests): preventConcurrentRequest along with staleTime #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #485
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
trackRequestResult no longer considers staleTime when skipping a request with status: fetching.
What is the current behavior?
It's currently possible to have concurrent requests even if preventConcurrentRequest is true because all requests that are 'fetching' are also stale.
Issue Number: #485
What is the new behavior?
The stale time is not considered at all when deciding wether to skip a request or not for fetching requests.
An alternative solution would be to set the stale time for request that are fetching, but this seems like a cleaner solution.
Does this PR introduce a breaking change?
I cannot see a reason this would be breaking.