Prepare Repo for Publishing autoapi Documentation via readthedocs - #31
Merged
alexdubois-ni merged 3 commits intoSep 2, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
🟢 Approval recommended
The documentation publishing setup and intentional API-surface changes are consistent and covered by updated tests.
Pull request overview
Prepares the project for Read the Docs publishing while refining its documented public API.
Changes:
- Adds Read the Docs configuration and README-based documentation landing page.
- Marks internal CLI, audit, and service helpers as private.
- Improves NI TLS terminology and sensitive-data guidance.
File summaries
| File | Description |
|---|---|
.readthedocs.yml |
Configures Poetry and Sphinx builds. |
docs/index.rst |
Includes the README and API reference. |
pyproject.toml |
Adds the documentation URL and updates metadata. |
README.md |
Clarifies installation, TLS defaults, and examples. |
src/nitlsconfig/__init__.py |
Updates package documentation. |
src/nitlsconfig/_service.py |
Updates service terminology. |
src/nitlsconfig/audit.py |
Makes transport-audit internals private. |
src/nitlsconfig/channel_tag.py |
Clarifies channel-tag documentation. |
src/nitlsconfig/cli.py |
Narrows the public API and improves key warnings. |
src/nitlsconfig/errors.py |
Updates NI TLS terminology. |
src/nitlsconfig/grpc_channel.py |
Uses private internals and refines documentation. |
tests/unit/test_audit.py |
Updates tests for private audit symbols. |
tests/unit/test_nitlsconfig.py |
Updates fixtures for private CLI helpers. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pkthong
previously approved these changes
Sep 2, 2026
… with what we intend to provide to nimi-python to make our details less vague
pkthong
approved these changes
Sep 2, 2026
alexdubois-ni
deleted the
users/adubois/getRepoReadyForSphynxDocumentation
branch
September 2, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Prepare Repo for Publishing autoapi Documentation via readthedocs
Why should this Pull Request be merged?
As-of-today, we only have documentation via our README and inline code. This does not follow the standard in nimi-python and daqmx-python as-of-today which use readthedocs and sphynx to publish documentation and even embed direct references.
When I am adding documentation to nimi-python and daqmx-python, this will make documentation more streamlined and consistent (no linking to direct github README pages or anything, etc).
This was recommended from folks like Jay and Brad.
While I AM at it, I am also re-evaluating our public API surface. The autoapi flagged a LOT of our API and made it VERY public facing. But, in my opinion only a very small portion of this should really be public. Furthermore, I fixed a lot of documentation to be more properly representative. Also, I renamed everything from NI-TLS to NI TLS to match what we have on gRPC device's documentation and what I am adding to nimi-python as well.
What testing has been done?
Checked the generated docs and they look reasonable now.