Add File.target
validation and escaping
#222
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds these in
files.ncl
:File.target
validation withstd.string.NonEmpty
,RelativePath
,NoParentTraversal
,File.target
shell-escaping inregenerate_one
.Before this change, the
files
field hasFile
with possibly pathologicaltarget | String
, e.g.:""
,"/etc/passwd"
,"../../../../../../../etc/passwd"
.This change adds schemas to eliminate such cases.
Also, in
regenerate_one
, we addshell_escape
tofile_descr.target
:By quoting with
$'…'
(dollar-sign and single-quotes) instead of"…"
(double-quotes), this correctly handles paths with characters such as"
,'
,*
,\
,\n
(newline),\t
(tabs),$
.