-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add GP error analysis experiment script #227
base: main
Are you sure you want to change the base?
Conversation
993f526
to
50002b3
Compare
|
||
# Simulate the fitting a number of times: every time the signal created will be a little | ||
# different | ||
for _ in range(repeats): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing about these repeats is that the GP itself is able to give us a std dev,
https://scikit-learn.org/stable/modules/generated/sklearn.gaussian_process.GaussianProcessRegressor.html#sklearn.gaussian_process.GaussianProcessRegressor.predict
but we are not using it,
eddymotion/src/eddymotion/model/_dipy.py
Line 141 in fcd9e94
return model.predict(gtab, return_std=False) |
so we may want to avoid an additional parameter and loop and use the former. Although I confess that as far as I know, none of DIPY's predict
methods return such value.
Add GP error analysis experiment script.
Use scikit-learn GP returned std error value.
50002b3
to
ea93c4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 63.97% 62.98% -1.00%
==========================================
Files 18 18
Lines 905 905
Branches 154 154
==========================================
- Hits 579 570 -9
- Misses 282 288 +6
- Partials 44 47 +3 ☔ View full report in Codecov by Sentry. |
Using the std deviation value of scikit-learn's GP regressor class (committed in |
Use `scikit-learn` k-folds.
@oesteban Adopted
|
Add GP error analysis experiment script.