Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests weekly to ensure we are still good #781

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Sep 13, 2024

also to check what the current state is since in fresh runs for

_____________________ test_embed_dicom_and_nifti_metadata ______________________
/home/runner/work/heudiconv/heudiconv/heudiconv/tests/test_dicoms.py:57: in test_embed_dicom_and_nifti_metadata
    embed_dicom_and_nifti_metadata(dcmfiles, out_prefix + ".nii.gz", infofile, None)
/home/runner/work/heudiconv/heudiconv/heudiconv/dicoms.py:659: in embed_dicom_and_nifti_metadata
    stack = ds.parse_and_stack(dcmfiles, force=True).values()
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dcmstack/dcmstack.py:1156: in parse_and_stack
    results = parse_and_group(src_paths,
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/dcmstack/dcmstack.py:1046: in parse_and_group
    dcm = pydicom.read_file(dcm_path, force=force)
E   AttributeError: module 'pydicom' has no attribute 'read_file'

that is with

Downloading pydicom-3.0.0-py3-none-any.whl.metadata (9.4 kB)

and pydicom released 5 days ago :-/ https://github.com/pydicom/pydicom/releases/tag/v3.0.0 says

heh, so we should also fix codebase (in a separate PR)

@yarikoptic yarikoptic added the tests Add or improve existing tests label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (a0a3635) to head (84694c1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   82.08%   82.03%   -0.06%     
==========================================
  Files          42       42              
  Lines        4215     4214       -1     
==========================================
- Hits         3460     3457       -3     
- Misses        755      757       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

d'oh we have replaced those already in

@yarikoptic yarikoptic merged commit ca24297 into nipy:master Sep 13, 2024
6 of 9 checks passed
Copy link

🚀 PR was released in v1.2.0 🚀

@yarikoptic yarikoptic deleted the enh-ci branch October 14, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant