Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding status token to fix badge error #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Jun 14, 2020

Note that the token is scoped to "status" so I don't think it can be used maliciously (and is intended for putting in a repo). Thoughts? I had thought this only was relevant for private repos, but it seems to be the case here. This will close #63

Signed-off-by: vsoch vsochat@stanford.edu

Signed-off-by: vsoch <vsochat@stanford.edu>
@satra
Copy link
Member

satra commented Jun 14, 2020

usually the token is not necessary (in nipype we simply have this: https://circleci.com/gh/nipy/nipype/tree/master.svg?style=svg in the readme file)

does it have something to do with the publicness of circle and to which repo/user it's connected to?

@vsoch
Copy link
Member Author

vsoch commented Jun 14, 2020

@satra I think that's probably correct. I don't think it's me!

image

Do we know who originally made the connection to circle?

@satra
Copy link
Member

satra commented Jun 14, 2020

well some magic happened. i set this project to free and open source and it looks like i can see the badge. i don't know who connected it though. perhaps we can close this and delete the api key for the badge and see what happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circle badge doesn't appear to be rendering in README
2 participants