Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix partprobe erroring sometimes with mdadm #654

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix partprobe erroring sometimes with mdadm #654

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b7c6aa
types.filesystem: add exfat pkgs
Lassulus Apr 22, 2024
e5874ca
mdadm: run sgdisk before partprobe
Lassulus May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/types/mdadm.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@
--force \
--homehost=any \
"''${disk_devices[@]}"
partprobe /dev/md/${config.name}
udevadm trigger --subsystem-match=block
udevadm settle
# for some reason mdadm devices spawn with an existing partition table, so we need to wipe it
sgdisk --zap-all /dev/md/${config.name}
partprobe /dev/md/${config.name}
Copy link
Member

@Mic92 Mic92 May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change exactly? Why do we have partprobe in the first place?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#358
#370

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we zap the device, wouldn't partprobe then not always fail?

fi
${lib.optionalString (config.content != null) config.content._create}
'';
Expand Down