Stop the opener check rejecting clips that open on "so" - #172
Conversation
Running the selection on a real episode turned up both failure directions in findOrphanOpener. "So actually, did you try to help him out?" and "So if you look at the latest NVIDIA GPUs" were rejected, and both are fine places to start a clip. Meanwhile "However, we asked Claude to do unrelated tasks" passed while contrasting with something the viewer never heard. "so" is now flagged only when the word after it points back, which keeps "So that's why we quit" and drops the false positives. Contraction stems are matched, so "that's" counts as "that". however, though, instead, otherwise and meanwhile join the openers. This came out of picking five moments by hand from the re-diarized episode and watching which good cuts the gate refused.
|
Warning Review limit reached
Next review available in: 12 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Found by running the selection on a real episode rather than by reading the code.
findOrphanOpenerwas wrong in both directions:So actually, did you try to help him out?So if you look at the latest NVIDIA GPUs, they run a thousand watts.However, we asked Claude to do unrelated tasks.So that's why we shut it down.sois the one opener that swings both ways, so it is now flagged only when the word after it points back. Contraction stems are matched, sothat'scounts asthat.however,though,instead,otherwiseandmeanwhilejoin the set, since each answers something the viewer never heard.The two rejected
solines were real moments I wanted from the episode, so this was costing picks.673 Python tests, 315 vitest.