feat: add result-bearing 1D NMR integral curves - #1
Merged
Conversation
Render normalized cumulative integral curves consistently across the canvas and export backends. Unify editable reference values for 1D and 2D NMR, synchronize integral results after processing and undo/redo, and document the updated workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
1D NMR integrals were primarily represented by editable rectangular regions.
The normal figure view did not provide cumulative integral curves, and the
result-bearing representation was not shared across screen and export
renderers.
Reference normalization was also fixed to 1.0 for 1D integrals and used a
different state model from 2D integrals.
Changes
Figuremodel.spacing-aware trapezoidal integration.
and clipboard vector rendering.
mitigation and viewport clamping.
cancellation, figure rebuilds, and processing changes.
producing invalid coordinates.
for non-monotonic series.
reintroducing the previous dual reference model.
Testing
cargo pr-check— passed all 7 checksnpm run buildindocs/— 63 pages built successfully