feat(canvas): unify visual styling and layout spacing - #4
Merged
Conversation
Add theme-derived canvas chrome roles, configurable accent colors, axis-furniture visibility controls, and object-aware visual spacing. Support inner-axis simplification, minimum-spacing presets, and shared layout behavior across grid arrangement, split, and tile operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establish a unified visual and layout system for the PlotX canvas.
Canvas editing chrome previously used scattered fixed colors, including
premultiplied translucent fills that could bleach underlying figures. Grid
gutters also described frame spacing only, so axis furniture could make the
visible separation between adjacent data areas much larger than expected.
This PR:
ChromeStylerole table for canvas editing feedback.explicit axis overrides.
while keeping plot frames non-overlapping.
tile retile operations.
Ribbon, and Canvas settings.
Tight requests a minimum of 2 mm but does not guarantee an exact 2 mm result:
axis furniture and physically constrained pages may require larger spacing.
Validation
cargo pr-checknpm run buildindocs/UI display logic
CommandId+description) and are searchable in the command palette.
availability and explanatory feedback.
unchanged and explains how to proceed.