[ObjectFifo] Add a pass to combine logical objFifos for connection reuse #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be addressing review comments from #755 (review) along with a few known issues before marking this "ready for review". |
Base automatically changed from
avarma_refactor_for_combining_objFifos
to
main
September 10, 2024 09:18
Abhishek-Varma
force-pushed
the
avarma_followup_combine_objFifos
branch
2 times, most recently
from
524f7b6
to
c14c69f
Compare
-- This commit adds a new pass `--iree-amdaie-logical-objectfifos-for-connection-reuse`. -- Essentially follows the narrative after splitting of logical objectFifos and is aimed to address point 4 of #644. Signed-off-by: Abhishek Varma <abhvarma@amd.com>
Abhishek-Varma
force-pushed
the
avarma_followup_combine_objFifos
branch
from
b9fbf35
to
4f0caea
Compare
| @@ -58,7 +58,7 @@ echo "Building IREE" | |||
|
|
|||
| $CMAKE_ARGS = @( | |||
| "-GNinja" | |||
| "-DCMAKE_BUILD_TYPE=Release" | |||
| "-DCMAKE_BUILD_TYPE=Debug" | |||
There was a problem hiding this comment.
This is the reason test_transaction isn't generated on Windows...
There was a problem hiding this comment.
I.e., once you put this back to Release Windows will pass again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- This commit adds a new pass
--iree-amdaie-logical-objectfifos-for-connection-reuse.-- Essentially follows the narrative after splitting of logical objectFifos
and is aimed to address point 4 of #644 .
Signed-off-by: Abhishek Varma abhvarma@amd.com