-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObjectFifo] Add a pass to combine logical objFifos for connection reuse #760
base: main
Are you sure you want to change the base?
Conversation
Will be addressing review comments from #755 (review) along with a few known issues before marking this "ready for review". |
524f7b6
to
c14c69f
Compare
-- This commit adds a new pass `--iree-amdaie-logical-objectfifos-for-connection-reuse`. -- Essentially follows the narrative after splitting of logical objectFifos and is aimed to address point 4 of #644. Signed-off-by: Abhishek Varma <abhvarma@amd.com>
b9fbf35
to
4f0caea
Compare
@@ -58,7 +58,7 @@ echo "Building IREE" | |||
|
|||
$CMAKE_ARGS = @( | |||
"-GNinja" | |||
"-DCMAKE_BUILD_TYPE=Release" | |||
"-DCMAKE_BUILD_TYPE=Debug" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the reason test_transaction
isn't generated on Windows...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e., once you put this back to Release
Windows will pass again.
-- This commit adds a new pass
--iree-amdaie-logical-objectfifos-for-connection-reuse
.-- Essentially follows the narrative after splitting of logical objectFifos
and is aimed to address point 4 of #644 .
Signed-off-by: Abhishek Varma abhvarma@amd.com