Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC][WIP] Merge prologue and epilogue into main loop #843

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

newling
Copy link
Contributor

@newling newling commented Oct 11, 2024

Inserting this pass after tiling is finished, but before vectorization (and before bufferization). This fails only in iree-amdaie-distribute-cores-and-objectfifos I don't think it'd be hard to get past that. I agree that making this robust to pattern matching is hard though. That said, if it were a pass in the tiling pipeline, it wouldn't need to be super robust, because the tiling pipeline isn't general purpose (we control what goes in and can annotate things).

I'm not suggesting this is a better approach than moving vectorization after bufferization and doing function outlining, I think that's good. Just throwing this option out there for future consideration

@Abhishek-Varma @jtuyls @MaheshRavishankar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant