[POC][WIP] Merge prologue and epilogue into main loop #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting this pass after tiling is finished, but before vectorization (and before bufferization). This fails only in
iree-amdaie-distribute-cores-and-objectfifos
I don't think it'd be hard to get past that. I agree that making this robust to pattern matching is hard though. That said, if it were a pass in the tiling pipeline, it wouldn't need to be super robust, because the tiling pipeline isn't general purpose (we control what goes in and can annotate things).I'm not suggesting this is a better approach than moving vectorization after bufferization and doing function outlining, I think that's good. Just throwing this option out there for future consideration
@Abhishek-Varma @jtuyls @MaheshRavishankar