Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vectorization][ObjectFifo] Enable larger Matmul + Truncf #856
base: main
Are you sure you want to change the base?
[Vectorization][ObjectFifo] Enable larger Matmul + Truncf #856
Changes from all commits
17f6bcc
d53d30e
ab1c09c
5a46ed2
1a02a64
248465a
4f6698f
95c937f
95143b9
b98d502
a036c81
f9a2f6b
f581744
9a56fa7
a342fdc
f0bcd45
ee1e49b
cf1d483
89fc4ca
5397238
1e7f4fe
3a2a7a7
c6de3ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't think it's a large shape.
Related question: does even larger shape work as well? You don't need to add more ci tests here, but I'm just curious of what's the largest shape that can work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, larger shapes like 1024x1024x1024 and 512x2048x4096 (MxNxK) all work.
But shapes like 1536x1536x2048 and 4096x4096x2048 (MxNxK) suffer from PM issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, maybe good to remove the above comment of "large shape".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make default
objectFifo
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made
objectFifo
default and have changed these tests to useair
pipeline explicitly, albeit commented.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments on why this is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the AIR tests are failed because @Abhishek-Varma changed the order of bufferization and vectorization?
FYI @erwei-xilinx may want to take a look at the changes and see if he could do anything to make pack-peel pipeline work for AIR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I am asking to add a comment in the code so someone reading it a few months from now (potentially), knows why this was disabled.