Skip to content

Commit

Permalink
Make gemmbench flags more uniform (#17)
Browse files Browse the repository at this point in the history
Use nargs=+ for data types and variants to align with extra compiler
args. This is a follow up after #10.
  • Loading branch information
kuhar authored Oct 8, 2024
1 parent c4f1a69 commit 1aa0004
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions gemmbench/gemm_bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import logging
import itertools
from pathlib import Path
import csv
import argparse
import sys
from utils import *
Expand Down Expand Up @@ -47,15 +46,16 @@ def compile_gemm(tag, config, kernel_dir, vmfb_dir, target, extra_compiler_args,
help="Extra command line arguments passed to the IREE compiler. The flags need to be specified without the `--` or `-`"
)
parser.add_argument(
"--dtypes", action='append', help="List of data types to benchmark. Defaults to all supported types."
"--dtypes", nargs='+', default=[], help="List of data types to benchmark. Defaults to all supported types."
)
parser.add_argument(
"--variants",
action='append',
nargs='+',
default=[],
help="List of matmul variants to benchmark. Default to all variants: NN, NT, TN, and TT."
)
parser.add_argument(
"--tag-regex",
"--tag_regex",
help="Regular expression for allowed benchmark tags. Defaults to all tags allowed.",
default=".*"
)
Expand Down

0 comments on commit 1aa0004

Please sign in to comment.