Fix accumulator and result types #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
requested review from
MaheshRavishankar,
saienduri,
monorimet and
harsh-amd
saienduri
reviewed
Oct 8, 2024
saienduri
reviewed
Oct 8, 2024
| operand_element_type = config.operand_element_type | ||
| acc_element_type = config.accumulator_element_type | ||
| result_element_type = config.result_element_type | ||
| assert not operand_element_type.startswith('i'), "Integer types not supported yet" |
There was a problem hiding this comment.
What's the reason integer types not supported? (would it not just work with this i8 operand, i32 accumulator, i8 result type?)
There was a problem hiding this comment.
Well they are not supported elsewhere either -- I didn't want to plumb through int8 support in the same PR
saienduri
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, perform f16 matmul with f32 as the accumulator type and truncate the result to f16. This is more realistic than using f16 as the accumulator type.
Keep track of operand, accumulator, and result types in
GemmConfig.