Add flags to filter gemm configs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can filter based on 3 criteria: 1. Data types: f16/bf16 2. Matmul variants: NN, NT, TN, and TT. (NT -- transpose B) 3. Tag regex, e.g., `"unet"` or `".*skinny"`. Also fix the number of parallel compilation jobs for small machines with < 20 cores.
saienduri
reviewed
Oct 2, 2024
|
Pretty sure the CI will fail because the workflow file should now have --dtypes instead of --dtype in it: https://github.com/nod-ai/iree-kernel-benchmark/blob/main/.github/workflows/run_bench.yml#L50 for example. Oh it is calling roofline from conv suite, we're good (will change as this propagates to other suites) |
|
I can add the same logic for the other two suites so we add this additional layer of filtering what shapes we run in the first place instead of just having filtering for the plots being generated as is currently. Thanks for the PR |
saienduri
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can filter based on 3 criteria:
"unet"or".*skinny"Also fix the number of parallel compilation jobs for small machines with < 20 cores.