feat: Add ABAC support and make custom actions more flexible #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodece @Shivansh-yadav13 please review |
Dallin343
changed the title
|
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
# [2.9.0](v2.8.0...v2.9.0) (2024-06-27) ### Features * Add ABAC support and make custom actions more flexible ([#168](#168)) ([e0bc88f](e0bc88f))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
After filing the ticket #167, I decided to create a fork which adds the requested feature. ABAC models allow request parameters to be object or class instances instead of only strings, however, the current implementation of
nest-authzrequires strings. This means that ABAC models in Casbin are unusable. In this PR, I added support by doing the following:AuthUserandAuthResourceasstring | Record<string, any>.usernameFromContexthas been changed touserFromContextwhich returns anAuthUser.Additionally, in order to support more flexible naming of actions (especially in use cases without the concept of possession), I made possession optional:
enablePosessionto the module options that defaults totrueif not provided.possessionoptional in@UsePermissionsand it defaults toAuthPossession.ANY"{actionVerb}:{possession}". If possession is disabled, actions are formatted as"{actionVerb}".Let me know what you think and if there are any improvements to make.