Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib@2.21.0 breaks build ⚠️ #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

urllib just published its new version 2.21.0.

State Failing tests ⚠️
Dependency urllib
New version 2.21.0
Type dependency

This version is covered by your current version range and after updating it in your project the build kept failing.

It looks like your project, in its current form, is malfunctioning and this update didn’t really change that. I don’t want to leave you in the dark about updates though. I recommend you get your project passing and then check the impact of this update again.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 41 commits .

  • acb306d Release 2.21.0
  • 269cb14 fix: should pass options to httpclient2 (#249)
  • 01a9c67 test: fix Promise not defined on 0.10
  • f7ec082 test: use assert instead of should
  • 12c8eb9 feat: add retry delay on httpclient2
  • 997d887 Release 2.20.0
  • 805201e deps: bump deps versions
  • bb5cfaa fix: keep the same req object across request and response event
  • b2e0ca7 Release 2.19.0
  • 3c0a16c feat: add dataAsQueryString params for convert data to query string (#240)
  • 409ccf9 Release 2.18.0
  • 98f73cd fix: use nextTick to prevent promise handling error.
  • 3cde873 refactor: move to separated files
  • 450d246 feat: add retry option
  • 20894d4 Release 2.17.1

There are 41 commits in total. See the full diff.


✨ Try the all new Greenkeeper GitHub Integration
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.

Screencast

Try it today. Free for private repositories during beta.

@codecov
Copy link

codecov bot commented Feb 27, 2017

Codecov Report

Merging #136 into master will increase coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   89.34%   89.94%   +0.59%     
==========================================
  Files           8        8              
  Lines         338      338              
  Branches       88       88              
==========================================
+ Hits          302      304       +2     
+ Misses         36       34       -2
Impacted Files Coverage Δ
lib/up.js 100% <0%> (+1.35%)
lib/utils.js 48.14% <0%> (+1.85%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce34145...4076b66. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants