mocha@3.4.0 breaks build ⚠️ #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greenkeeperio-bot, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @helloyou2012 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 89.34% 89.64% +0.29%
==========================================
Files 8 8
Lines 338 338
Branches 88 88
==========================================
+ Hits 302 303 +1
+ Misses 36 35 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
mocha just published its new version 3.4.0.
This version is covered by your current version range and after updating it in your project the build kept failing.
It looks like your project, in its current form, is malfunctioning and this update didn’t really change that. I don’t want to leave you in the dark about updates though. I recommend you get your project passing and then check the impact of this update again.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 119 commits .
7554b31Add Changelog for v3.4.09f7f7edAdd--trace-warningsflag92561c8Add--no-warningsflagceee976lint test/integration/fixtures/simple-reporter.jsdcfc094Revert "usesemistandarddirectly"93392ddno special case for macOS running Karma locally4d1d91d--allow-uncaught cli optionfb1e083fix allowUncaught in browser4ed3fc5Add license report and scan statusfb1687e:ship: Release v3.3.01943e02Add Changelog for v3.3.0861e968Refactor literal play-icon hex code to a var1d3c5bcFix typo in karma.conf.js9bd9389Fix spec paths in test HTML files0a93024Adds tests for loading reporters w/ relative/absolute paths (#2773)There are 119 commits in total. See the full diff.