Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options.method alias options.type is invalid #490

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

autrol
Copy link
Contributor

@autrol autrol commented Feb 22, 2024

No description provided.

@killagu killagu requested a review from fengmk2 February 22, 2024 06:42
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee9a786) 98.68% compared to head (7f79fce) 98.68%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          10       10           
  Lines        1595     1597    +2     
  Branches      271      271           
=======================================
+ Hits         1574     1576    +2     
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 75c5989 into node-modules:master Feb 22, 2024
19 of 20 checks passed
fengmk2 pushed a commit that referenced this pull request Feb 22, 2024
[skip ci]

## [3.22.4](v3.22.3...v3.22.4) (2024-02-22)

### Bug Fixes

* options.method alias options.type is invalid ([#490](#490)) ([75c5989](75c5989))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants